search

voteblake / csaf-rs

CSAF data types for Rust, building towards VEX support
MIT License
0 stars 5 forks source link

Implement Clone, and maybe PartialEq, Eq #15

Open ctron opened 1 year ago

ctron commented 1 year ago

In order to use this with Yew in a WebAssembly environment it would be necessary sometimes to clone the Csaf document. Also, it would be helpful in some cases to have PartialEq and Eq.

If you like, I can submit a PR for this.

voteblake commented 1 year ago

I've merged Clone and PartialEq implementations. Eq blocked on packageurl, whose primary type only implements PartialEq. Checking with them on Eq feasibility before cutting a release for this.

voteblake commented 1 year ago

Opened https://github.com/althonos/packageurl.rs/pull/10

voteblake commented 1 year ago

@ctron would a patch release with just Clone and PartialEq be helpful? Happy to cut one while we wait on the packageurl Eq decision.

ctron commented 1 year ago

@ctron would a patch release with just Clone and PartialEq be helpful? Happy to cut one while we wait on the packageurl Eq decision.

Very generous :) But for now, we can just work with a patched dependency. If that's ok, and we do find a need, I would ping you in the future.

ctron commented 1 year ago

@voteblake It would be great if we could have a release now.

ctron commented 10 months ago

@voteblake Could to make a release with those changes?

ctron commented 9 months ago

As we have another bugfix coming up (see #27), I am wondering of this project is still alive?

helio-frota commented 6 months ago

I am wondering of this project is still alive?

@voteblake hi :+1:

https://github.com/althonos/packageurl.rs/pull/10 merged

Any chance to move the project forward thanks :+1: