Update application icon

voteflux / digipol

An app to allow Australian Voters to vote on current issues and bills in the parliament.

https://digipol.app

GNU General Public License v3.0

60 stars 9 forks source link

Update application icon #123

Closed connorhsm closed 4 years ago

connorhsm commented 4 years ago

Problem: Android application icon displaying incorrectly.

Solution:

Made use of flutter-launcher-icons adaptive foreground and background attributes to better display the app logo on Android with a solid background.
Updated Android fallback icon, also used as the iOS icon.
Removed original icon PNG and SVG.

connorhsm commented 4 years ago

@XertroV Nothing from Atomist?

XertroV commented 4 years ago

@XertroV Nothing from Atomist?

There was an error on the 7th for like an hour (not sure if it was my end or theirs) and looks like the automatic reconnection didn't work. Restarted all the SDMs

XertroV commented 4 years ago

oh, actually maybe they were fine - not sure. However, this is a PR from your repo, and there's a filter on the source (needs to be voteflux organisation) at the moment.

XertroV commented 4 years ago

curious, the checks are registering here, but are the same checks as here: https://github.com/voteflux/voting_app/pull/124 (which I created to trigger the thing)

so must be by sha hash

atomist[bot] commented 4 years ago

Build outputs for d0c01487ed254afcc98d723aeb845e98ee3767e2

Debug APK: http://android.preview.flx.dev/fluxApp-d0c0148.apk

:tada:

atomist[bot] commented 4 years ago

Build outputs for d0c01487ed254afcc98d723aeb845e98ee3767e2

Debug IPA: http://ios.preview.flx.dev/fluxApp-d0c0148.ipa

:tada:

XertroV commented 4 years ago

@connorhsm - you should be able to push to https://github.com/voteflux/voting_app/tree/update-icon

connorhsm commented 4 years ago

Thanks @XertroV Should I close this PR and open a new one from the branch > master?

XertroV commented 4 years ago

Thanks @XertroV Should I close this PR and open a new one from the branch > master?

You can just change the target of this PR. I've pushed your commits to this repo already (same branch name I think). #124 was the PR I opened to check things were working.

I will review on the weekend if it's not reviewed by someone else before then.

connorhsm commented 4 years ago

As far as I can see, I can't modify the repo/branch that the PR is comparing from. Given that the checks are now functioning for this PR and have passed successfully, I would assume there is no issue with continuing with this PR. Please advise otherwise.

Awaiting review.

XertroV commented 4 years ago

Given that the checks are now functioning for this PR and have passed successfully, I would assume there is no issue with continuing with this PR. Please advise otherwise.

That's correct. I'll check your permissions b/c you should be able to, though maybe you're only in python groups or something.

Awaiting review.

Ack @KipCrossing @oscarmanderj ? (Like I said, will review this weekend in lieu of any other reviewer)