search

voteflux / digipol

An app to allow Australian Voters to vote on current issues and bills in the parliament.
https://digipol.app
GNU General Public License v3.0
60 stars 9 forks source link

[BUG] Pdf-Viewer Crashes #158

Closed KipCrossing closed 3 years ago

KipCrossing commented 3 years ago

Problem

Describe the bug When attempting to open a bill pdf, the app crashes.

To Reproduce Steps to reproduce the behavior:

  1. Go to bill page
  2. Click on 'view bill text'
  3. App crashes

Expected behavior Open and view a pdf

Smartphone

Solution

This is related to https://github.com/lubritto/Pdf_Viewer_Plugin/issues/10

There is an open PR here with a fix https://github.com/lubritto/Pdf_Viewer_Plugin/pull/27

We could wait for a bit OR just send to browser.

OR use this https://github.com/seenickcode/flutter_webviews

KipCrossing commented 3 years ago

@oscarmanderj This only happens on the release APK and is fine on the debug APK

KipCrossing commented 3 years ago

Should also test it it fixes #4

KipCrossing commented 3 years ago

@oscarmanderj

I just published 0.1.7 with the pdf fix, but it still crashes the same way.

KipCrossing commented 3 years ago

I think using https://github.com/seenickcode/flutter_webviews is the go

KipCrossing commented 3 years ago

Temp fix in version 0.1.9 where it sends the user to the browser. Still needs to be fixed in the master branch though.