search

voteflux / digipol

An app to allow Australian Voters to vote on current issues and bills in the parliament.
https://digipol.app
GNU General Public License v3.0
60 stars 9 forks source link

UI colours #179

Closed magnetism2000 closed 3 years ago

magnetism2000 commented 3 years ago

Problem: UI not reflective of new UI.

This PR is not an entire completion of the rework, however it is worth merging into master so others can begin polishing.

Solution:

thatwasmycat commented 3 years ago

Looking great! @oscarmanderj

KipCrossing commented 3 years ago

I'm getting pdf_viewer problems on this one

lib/ui/views/bills/pdf_viewer.dart:104:14: Error: The method 'PdfViewer' isn't defined for the class '_PdfWidgetState'.
 - '_PdfWidgetState' is from 'package:voting_app/ui/views/bills/pdf_viewer.dart' ('lib/ui/views/bills/pdf_viewer.dart').
Try correcting the name to the name of an existing method, or defining a method named 'PdfViewer'.
      return PdfViewer(
             ^^^^^^^^^

The new version breaks our app. We aren't going to be using this anyway.

The temp fix that I added in stable is:

https://github.com/voteflux/voting_app/blob/de84cae5b2da748fe506827e1a640dd1834e5837/lib/ui/views/bills/bill_view.dart#L127

Using:

import 'package:url_launcher/url_launcher.dart';
KipCrossing commented 3 years ago

This PR is good as now we will all be aligned with the theme colors when branching off the master branch.