search

votemike / react-accordion

A simple, extendable, accessible React accordion using semantic HTML.
https://votemike.github.io/react-accordion/
MIT License
1 stars 0 forks source link

Cleanup old preview deployments #11

Open cat-markwylde opened 2 years ago

cat-markwylde commented 2 years ago

Create a github action to delete any preview directories from the gh-pages branch.

So I think now we have moved to the pull-requests/$pullRequestId structure, we can now create a scheduled cron github action, that every day deletes closed PR previews.

cat-markwylde commented 2 years ago

Instead of deploying into votemike.github.io/git-commit-hash, we could deploy to votemike.github.io/pr-number, and then delete once the PR has been closed for a certain amount of time. Maybe a month?

votemike commented 2 years ago

And if we do it by PR number... URLs will be more easily guessable and permanent. Previous previews for that PR will be overwritten.

markwylde commented 2 years ago

Updated ticket description