search

votinginfoproject / vip-specification

The Voting Information Project XML specification.
http://vip-specification.readthedocs.io/en/release/
Other
75 stars 30 forks source link

Corrects invalid ID values in sample XML #435

Closed afsmythe closed 2 years ago

afsmythe commented 2 years ago

Provides updated and valid ID values in v6 sample feed.

jswiesner commented 2 years ago

This LGTM. The updated XML file validates against the v6 XSD:

$ xmllint --schema vip_spec.xsd --noout vipfeed-04013-2020-11-03.xml 
vipfeed-04013-2020-11-03.xml validates

Whereas before:

$ xmllint --schema vip_spec.xsd --noout ../sample_feed\ 2/vipfeed-04013-2020-11-03.xml 
../sample_feed%202/vipfeed-04013-2020-11-03.xml:2: element Source: Schemas validity error : Element 'Source', attribute 'id': '4013555' is not a valid value of the atomic type 'xs:ID'.
../sample_feed%202/vipfeed-04013-2020-11-03.xml:10: element Election: Schemas validity error : Element 'Election', attribute 'id': '401311032020' is not a valid value of the atomic type 'xs:ID'.
../sample_feed 2/vipfeed-04013-2020-11-03.xml fails to validate
afsmythe commented 2 years ago

Will merge this after https://github.com/votinginfoproject/vip-specification/pull/433 is merged.

afsmythe commented 2 years ago

Closing this and handling sample XML updates in https://github.com/votinginfoproject/vip-specification/pull/433