search

votingworks / bmd

GNU General Public License v3.0
13 stars 7 forks source link

don't send extra args to kiosk.print for test deck #1503

Closed benadida closed 3 years ago

benadida commented 3 years ago

doing so appears to crash kiosk, likely because we're sending an event and it's expecting an options object.

we should fix kiosk at some point, but simplest fix right now is to not send anything to kiosk.print() unless we mean to.

netlify[bot] commented 3 years ago

Deploy preview for vw-bmd ready!

Built with commit abc6c975c93cc36a63a6bb81842441ef69b72f78

https://deploy-preview-1503--vw-bmd.netlify.app

beausmith commented 3 years ago

Man! This has bitten me before 🤦‍♂️

benadida commented 3 years ago

Man! This has bitten me before

And to be clear this is because kiosk-browser changed from under bmd, so ... just a sign of us needing to figure out better full integration testing.