search

votingworks / bmd

GNU General Public License v3.0
13 stars 7 forks source link

Feat/functional components #1513

Closed beausmith closed 3 years ago

beausmith commented 3 years ago

All but the AppRoot component.

beausmith commented 3 years ago

not seeing test fail locally

eventualbuddha commented 3 years ago

FWIW this would be a refactor: commit type since it doesn't change functionality, right?

beausmith commented 3 years ago

Correct @eventualbuddha. I still don't have this enum set memorized.

netlify[bot] commented 3 years ago

Deploy preview for vw-bmd ready!

Built with commit 190c3e1db482834e1bfd0cc87285b6987f2737ed

https://deploy-preview-1513--vw-bmd.netlify.app

eventualbuddha commented 3 years ago

Correct @eventualbuddha. I still don't have this enum set memorized.

Yeah, I still look it up sometimes. For feat I ask myself "Does the end-user of this app/library have a new feature as a result of this change?". If yes, and that new feature isn't actually just a fix, then feat is appropriate.