votingworks / vxsuite

https://voting.works
30 stars 6 forks source link

nh-accuvote: cross party endorsement contest tabulation errors #2072

Closed mattroe closed 2 years ago

mattroe commented 2 years ago

Description

Repro

  1. Scan a ballot where Edward Randolph - Republican is the only mark. It will be flagged as a blank ballot. Note: if you "count" the blank ballot, it will actually be counted as a mark for the correct Edward Randolph candidate selection.
  2. Scan a ballot where Edward Randolph - Republican is the only mark for the contest. Edward Randolph will not appear on the tally report.
  3. Scan a ballot where Edward Randolph - Republican and write-in is marked and neither mark will be tabulated, nor will the scanner reject as an overvote.

Related conditions that are tabulated correctly

eventualbuddha commented 2 years ago

This is because convertMarksToAdjudicationInfo finds the first oval that matches the contestId/optionId, expecting that there's only one. Instead, we should select all of the ones that match and consider it a mark if any of them are marked.