USB drives with volume titles that contain spaces can crash the app

votingworks / vxsuite

https://voting.works

29 stars 5 forks source link

USB drives with volume titles that contain spaces can crash the app #4833

Open arsalansufi opened 2 months ago

arsalansufi commented 2 months ago

USB drives with volume titles that contain spaces can crash the app

Issue automatically created from Slack feedback reported by drew: https://votingworks.slack.com/archives/CJU9MSC6S/p1714773835294109?thread_ts=1714773835.294109&cid=CJU9MSC6S

arsalansufi commented 2 months ago

Copying from Slack:

I bet this is because we don't wrap variables in the relevant shell scripts with quotes, e.g., https://github.com/votingworks/vxsuite/blob/663ec51255d7b0c8c1b8499bbdb24fb935eb8f0a/libs/usb-drive/scripts/unmount.sh#L25