The tutorial might be outdated

metehan commented 3 years ago

When I try to follow the tuorial I am getting errors and deprecation warnings

deps.edn

{:deps {io.vouch/krell {:git/url "https://github.com/vouch-opensource/krell.git"
                        :sha "35786a94f4dd4bce4cf80542501e4d105184452a"}
        io.vouch/reagent-react-native {:git/url "https://github.com/vouch-opensource/reagent-react-native.git"
                                       :sha "54bf52788ab051920ed7641f386177374419e847"}
        reagent {:mvn/version "0.10.0"
                 :exclusions [cljsjs/react cljsjs/react-dom]}}}

clj -m cljs.main --install-deps


DEPRECATED: Libs must be qualified, change reagent => reagent/reagent (deps.edn)
DEPRECATED: Libs must be qualified, change reagent => reagent/reagent (/home/r/.gitlibs/libs/io.vouch/reagent-react-native/54bf52788ab051920ed7641f386177374419e847/deps.edn)
DEPRECATED: Libs must be qualified, change reagent => reagent/reagent (/home/r/.gitlibs/libs/io.vouch/reagent-react-native/54bf52788ab051920ed7641f386177374419e847/deps.edn)
WARNING: When invoking clojure.main, use -M
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: undefined@undefined
npm ERR! Found: react@16.13.0
npm ERR! node_modules/react
npm ERR!   react@"16.13.0" from the root project
npm ERR!   peer react@"^16.8" from @react-native-community/async-storage@1.10.0
npm ERR!   node_modules/@react-native-community/async-storage
npm ERR!     @react-native-community/async-storage@"1.10.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.1" from react-native@0.64.0
npm ERR! node_modules/react-native
npm ERR!   peer react-native@">=0.59" from @react-native-community/async-storage@1.10.0
npm ERR!   node_modules/@react-native-community/async-storage
npm ERR!     @react-native-community/async-storage@"1.10.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! ```

apostolou commented 3 years ago

@metehan I think that the tutorial is outdated indeed. What I did in order to move fwd is :

use qualified name for reagent dependency
Use the most recent release of Krell (sha : d0e115309580ca0bdc782e4ca396df66a357d212)
I downgraded from NPM 6 to NPM 7, see issue . If you find a better solution, I'd be interested to learn it. My deps.edn file looks like :

{:deps {org.clojure/clojurescript {:mvn/version "1.10.844"}
             io.vouch/krell {:git/url "https://github.com/vouch-opensource/krell"
                                     :sha "d0e115309580ca0bdc782e4ca396df66a357d212"}
             io.vouch/reagent-react-native {:git/url "https://github.com/vouch-opensource/reagent-react-native.git"
                                                                 :sha "0fe1c600c9b81180f76b94ef6004c2f85e7d4aa0"}
            reagent/reagent {:mvn/version "0.10.0"
                                         :exclusions [cljsjs/react cljsjs/react-dom]}}}

Hope this helps ...

girishso commented 2 years ago

using latest reagent version "1.1.0" in deps.edn fixes the issue.

vouch-opensource / krell

The tutorial might be outdated #124