search

vouch-opensource / krell

Simple ClojureScript React Native Tooling
Eclipse Public License 1.0
680 stars 36 forks source link

Android fix includes ack / eval timeout bug #29

Closed swannodette closed 4 years ago

swannodette commented 4 years ago

Now that we send a single big message, the receipt of the ack is now tied to the runtime cost of eval.

That is, long evaluations will fail. We should reorganize the code a bit for Android such that the ack can be read immediately w/o re-introducing out of order message arrival

One simple way maybe to schedule the result write via a setTimeout?

swannodette commented 4 years ago

We also should just remove :ack-timeout instead base it on some reasonable rate data transfer for local network based development - i.e. 100K/s

swannodette commented 4 years ago

https://github.com/vouchio/krell/commit/c1e386d2e64e482c7ce933ea6b9e892de09fc1b9