vouch-opensource / krell

Simple ClojureScript React Native Tooling
Eclipse Public License 1.0
675 stars 37 forks source link

Building with "-c -r" doesn't produce a krell_assets.js file #58

Closed olivergeorge closed 4 years ago

olivergeorge commented 4 years ago

Tested against latest commit in master (88c431)

AwesomeProject % cat deps.edn                         
{:deps {io.vouch/krell {:git/url "https://github.com/vouch-opensource/krell.git"
                        :sha "88c4319de923e914c6888db54c0644b6f1ab0f2d"}
        io.vouch/reagent-react-native {:git/url "https://github.com/vouch-opensource/reagent-react-native.git"
                                       :sha "54bf52788ab051920ed7641f386177374419e847"}
        reagent {:mvn/version "0.10.0"
                 :exclusions [cljsjs/react cljsjs/react-dom]}}}

AwesomeProject % cat build.edn                        
{:main awesome-project.core
 :output-to "target/main.js"
 :output-dir "target"}

AwesomeProject % ls -la src/awesome_project/c*
total 32
-rw-r--r--@ 1 olivergeorge  staff  11012 22 Apr 10:08 cljs.png
-rw-r--r--  1 olivergeorge  staff    444 22 Apr 10:33 core.cljs

AwesomeProject % cat src/awesome_project/core.cljs    
(ns awesome-project.core
  (:require [reagent.core :as r]
            [reagent.react-native :as rn]))

(def logo (js/require "./cljs.png"))

(defn ^:export -main [& args]
  (r/as-element
    [rn/view {:style {:flex 1 :align-items "center" :justify-content "center"}}
     [rn/image {:source logo :style  {:width 80 :height 80 :margin-bottom 30}}]
     [rn/text {:style {:font-size 50}} "Hello Krell!"]]))

AwesomeProject % clj -m krell.main -co build.edn -c -r
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

In another terminal we see no krell_assets.js

olivergeorge@Condense-iMac AwesomeProject % ls target 
awesome_project     cljs_deps.js        clojure         inferred_externs.js main.js         process
cljs            cljsc_opts.edn      goog            krell_repl.js       npm_deps.js     reagent

And Metro reports

Unable to resolve module `./krell_assets.js` from `target/krell_repl.js`: 

None of these files exist:
  * target/krell_assets.js(.native|.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)
  * target/krell_assets.js/index(.native|.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)

RCTFatal
__28-[RCTCxxBridge handleError:]_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
UIApplicationMain
main
start
swannodette commented 4 years ago

Thanks!