vouch-opensource / krell

Simple ClojureScript React Native Tooling
Eclipse Public License 1.0
675 stars 37 forks source link

Support :closure-defines in dev builds #74

Closed olivergeorge closed 4 years ago

olivergeorge commented 4 years ago

Looks like the closure-defines option is not picked up in first build.

Steps to repeat:

Expect: greeting is always "G'day Krell"

Actual: Greeting is "Hello Krell" until core.cljs is recompiled.

% cat build.edn
{:main awesome-project.core
 :output-to "target/main.js"
 :output-dir "target"
 :closure-defines {awesome-project.core/greeting "G'day"}}

% cat src/awesome_project/core.cljs
(ns awesome-project.core
  (:require [reagent.core :as r]
            [reagent.react-native :as rn]))

(goog-define greeting "Hello")

(defn ^:export -main [& args]
  (r/as-element
    [rn/view {:style {:flex 1 :align-items "center" :justify-content "center"}}
     [rn/text {:style {:font-size 50}} greeting " Krell!"]]))
olivergeorge commented 4 years ago

Equivalent test using Clojurescript Getting Started guide works.