search

vouch-opensource / krell

Simple ClojureScript React Native Tooling
Eclipse Public License 1.0
675 stars 37 forks source link

Reagent Tutorial is out of date vs Master & Readme details #96

Closed olivergeorge closed 4 years ago

olivergeorge commented 4 years ago

I think the tutorial needs a few tweaks to avoid confusing people.

If the SHA was updated to the current latest master commit then...

Android permission bit can be removed... https://github.com/vouch-opensource/krell/commit/a21b763b2f48093f5dd85cec8fcfa6c465aa98ad#diff-04c6e90faac2675aa89e2176d2eec7d8

I think there are a few known gotchas with the version referred to in the tutorial but I can't recall details.

Master seems stable.

swannodette commented 4 years ago

Fixed