search

vouch-opensource / mcumgr-client

client for mcumgr commands
Apache License 2.0
31 stars 13 forks source link

Add the `Cargo.lock` file to the repository #31

Closed otavio closed 3 months ago

otavio commented 3 months ago

Hey there! Just a quick heads up — it's a good idea to include the lock file inside the repository for your applications. This makes it easier to ensure that the exact versions used for the application can be replicated.

I encountered this issue when packaging the application for NixOS, and I'm considering removing the manually created lock file from Nix's Packages repository.

Do you have any thoughts on that?

otavio commented 3 months ago

Ref: https://github.com/NixOS/nixpkgs/pull/332799 and https://github.com/NixOS/nixpkgs/pull/332803

Frank-Buss commented 3 months ago

Sounds good, I'll add a Cargo.lock. Do you need a new release then?

otavio commented 3 months ago

It would be awesome, so that would allow us to upgrade to that new release and drop the manually created lock.

Frank-Buss commented 3 months ago

new release is done