search

voucherifyio / voucherify-dotNET-sdk

.Net SDK for Voucherify - coupons, vouchers, promo codes http://www.voucherify.io
http://www.voucherify.io
MIT License
12 stars 16 forks source link

Add Metadata attribute to the ValidationPromotionTier Model #100

Closed NicolasNogueiraLimeLife closed 1 year ago

NicolasNogueiraLimeLife commented 1 year ago

Hi, when I was implementing a feature with validating promotions, I discover that the promotion tier didn't have the metadata that I define for him. So this pull request is to add metadata attribute to the ValidationPromotionTier Model.

bandraszyk commented 1 year ago

Thank you for your contributions, I have released version 7.14 with your change, it should be available soon in nuget repository

NicolasNogueiraLimeLife commented 1 year ago

Hi Bandro,

Thanks a lot for your fast reply and update on the nugget package.

Unfortunatly, I discover a other problem with metadata. This time the problem was in the Redeemable object where the metadata attribute is "null". I made a PR to fix it. Please can you check it and see if this PR is the solution of the problem.

PR link : https://github.com/voucherifyio/voucherify-dotNET-sdk/pull/101

Best regards Nicolas Nogueira from LimeLife

On Tue, Dec 13, 2022 at 9:45 AM Bandro @.***> wrote:

Thank you for your contributions, I have released version 7.14 with your change, it should be available soon in nuget repository

— Reply to this email directly, view it on GitHub https://github.com/voucherifyio/voucherify-dotNET-sdk/pull/100#issuecomment-1347940741, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4FSCBMHZWDI2CXSNXHSCOTWNAZTLANCNFSM6AAAAAAS3WVGVY . You are receiving this because you authored the thread.Message ID: @.***>

NicolasNogueiraLimeLife commented 1 year ago

Hi again Brando,

I also found that when validating a voucher we doesn't have the metadata so I create a PR to try to fix it. Please check if that is correct. PR link : https://github.com/voucherifyio/voucherify-dotNET-sdk/pull/102

Have a nice day. Nicolas Nogueira from LimeLife

On Tue, Dec 13, 2022 at 4:51 PM Nicolas Nogueira < @.***> wrote:

Hi Bandro,

Thanks a lot for your fast reply and update on the nugget package.

Unfortunatly, I discover a other problem with metadata. This time the problem was in the Redeemable object where the metadata attribute is "null". I made a PR to fix it. Please can you check it and see if this PR is the solution of the problem.

PR link : https://github.com/voucherifyio/voucherify-dotNET-sdk/pull/101

Best regards Nicolas Nogueira from LimeLife

On Tue, Dec 13, 2022 at 9:45 AM Bandro @.***> wrote:

Thank you for your contributions, I have released version 7.14 with your change, it should be available soon in nuget repository

— Reply to this email directly, view it on GitHub https://github.com/voucherifyio/voucherify-dotNET-sdk/pull/100#issuecomment-1347940741, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4FSCBMHZWDI2CXSNXHSCOTWNAZTLANCNFSM6AAAAAAS3WVGVY . You are receiving this because you authored the thread.Message ID: @.***>