voucherifyio / voucherify-dotNET-sdk

.Net SDK for Voucherify - coupons, vouchers, promo codes http://www.voucherify.io
http://www.voucherify.io
MIT License
12 stars 16 forks source link

Custom error message is not mapped to VoucherifyClientException #106

Closed kanclalg closed 1 year ago

kanclalg commented 1 year ago

Custom error message is not mapped to VoucherifyClientException.

E.g. response:

{
   "code":400,
   "key":"customer_rules_violated",
   "message":"customer does not match validation rules",
   "details":"Referral Code cannot be redeemed because of violated validation rules: val_4Rz40vs2mHXZ",
   "request_id":"v-0c625e154445522451",
   "resource_id":"rf_0c625e15590ee0d561",
   "resource_type":"redemption",
   "error":{
      "message":"Sorry, this code cannot be used by users who have already taken at least one trip."
   }
}

https://support.voucherify.io/article/264-how-can-i-create-custom-errors From your documentation: The content of the custom error message is going to be returned in the error object under message property. https://github.com/voucherifyio/voucherify-dotNET-sdk/blob/master/src/Voucherify/Core/Exceptions/VoucherifyClientException.cs

bandraszyk commented 1 year ago

Resolved in new version 7.18.

https://github.com/voucherifyio/voucherify-dotNET-sdk/commit/5ff3171a8db5e3eab5f4aedecb8bcb851c898898