search

voucherifyio / voucherify-dotNET-sdk

.Net SDK for Voucherify - coupons, vouchers, promo codes http://www.voucherify.io
http://www.voucherify.io
MIT License
12 stars 16 forks source link

VoucherifyClientException properties not being mapped #107

Closed kanclalg closed 1 year ago

kanclalg commented 1 year ago

You've just added new properties to VoucherifyClientException (https://github.com/voucherifyio/voucherify-dotNET-sdk/commit/5ff3171a8db5e3eab5f4aedecb8bcb851c898898) but they're not being mapped.

Issue lies here: https://github.com/voucherifyio/voucherify-dotNET-sdk/blob/master/src/Voucherify/Core/Communication/ApiClient.Async.cs#L210

you're creating new exception here, but constructor does not contain new properties

bandraszyk commented 1 year ago

@kanclalg you are correct, I forgot about it, mapping was added in 7.18.1 - just released.

kanclalg commented 1 year ago

Thanks. I can confirm it's working fine now. Closing.