DomBarber commented 1 month ago

Description:

This pull request

Implements colonist, prisoner and slave medical buttons to the BPC defaults window, each integrated with the corresponding vanilla core functionality for the same.
Removes some redundant code surrounding old BPC medical defaults implementation
Addresses console errors relating to no ideology DLC (Slave functionality will now be ignored if the Ideology DLC is not present, preventing irrelevant console errors from appearing)

Before:

1)

Outdated code for medicine defaults was superseded by core game functionality. Better Pawn Control has hidden/commented out a lot of this, however redundant legacy code remains within the project.
As seen in the image, we are now missing default medicine options that would be expected here. The core game implementation for medicine defaults is more hidden and may not be initially found by some users (myself included...)

Missing buttons example:

2)

Better Pawn Control implements functionality for slaves, but they do not exist within Ideology DLC. We are checking for some values surrounding them upon loading a save, that will not exist without DLC. Results in red errors in dev console.

Errors (Ideology compatibility)

After:

1)

Outdated code for medicine defaults removed. Added integration UI buttons with vanilla core system, allowing the value to be set in either BPC menu or vanilla, with any changes reflected.

Without Ideology

With Ideology

2)

Added logic for values related to slavery, checking for ideology DLC before using, no more errors.

No Errors (Ideology compatibility)

voult2 commented 1 month ago

Hi DomBarber, this is great and clean. I decided NOT to add this feature since it was already in Vanilla. However, since what you did is integrated with core vanilla this is good. Merged! Thank you