voutcn / megahit

Ultra-fast and memory-efficient (meta-)genome assembler
http://www.ncbi.nlm.nih.gov/pubmed/25609793
GNU General Public License v3.0
596 stars 135 forks source link

Add intermediate megahit_core_popcnt for CPUs that have ABM but not BMI2 #229

Closed sjaenick closed 5 years ago

sjaenick commented 5 years ago

Our compute cluster is based on Intel(R) Xeon(R) CPU E5-2670 v2 CPUs which provide the ABM (i.e. POPCNT, LZCNT) extensions but neither BMI nor BMI2; this PR adds an additional megahit core binary to address these scenarios.

codecov[bot] commented 5 years ago

Codecov Report

Merging #229 into master will increase coverage by 0.02%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   90.44%   90.47%   +0.02%     
==========================================
  Files          98       98              
  Lines        6460     6464       +4     
==========================================
+ Hits         5843     5848       +5     
+ Misses        617      616       -1
Impacted Files Coverage Δ
src/main.cpp 77.5% <50%> (-3.06%) :arrow_down:
src/sorting/seq_to_sdbg.cpp 99.53% <0%> (+0.23%) :arrow_up:
src/sorting/kmer_counter.cpp 99.11% <0%> (+0.44%) :arrow_up:
src/idba/sequence.cpp 39.74% <0%> (+1.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93d8ccd...66cd94b. Read the comment docs.

voutcn commented 5 years ago

LGTM. Thank you for your contribution. The changes are merged into dev and will be released in the next version.