Improve error messages - Githubissues

yanisurbis commented 1 year ago

Problem statement:

if during an initialization a module throws an error it's hard to understand what module produced this error
the error, in this case, is creator is not a constructor (because of how error handling is done in Container.createInstance function)

This PR attempts to fix this problem by introducing a function that helps to distinguish between classes and function so we avoid swallowing the error during a module initialization.

we added tests for that
we also updated typescript, jest and ts-jest because { cause: e } is not supported in older TS versions

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
brandi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2023 11:36am

acron0 commented 1 year ago

This suffers from https://github.com/vovaspace/brandi/issues/35, which is fixed in https://github.com/vovaspace/brandi/pull/38

vovaspace / brandi

Improve error messages #37