search

vovkasm / react-native-web-image

An image component for react-native with persistent disk and memory caching.
MIT License
146 stars 25 forks source link

Images with White Background Render Off-White (Android) #17

Open jcady opened 6 years ago

jcady commented 6 years ago

I've noticed that images that have a white background do not render the color properly when using this library (on Android). Here are some screenshots of my app putting an image on a white background from stock RN component and this library:

Stock: rn_image

react-native-web-image: rn_web_image

Source image: f69ca69857

jcady commented 6 years ago

I fixed this by upgrading Glide to v4.

https://github.com/bumptech/glide/issues/1589

vovkasm commented 6 years ago

Thanks! Good to know! Yes glide v3 defaults to RGB_565 format, but v4 to ARGB_8888 https://bumptech.github.io/glide/doc/migrating.html#decodeformat

Meanwhile I hope to make glide v4 near weekend, wip branch feature/update-glide (it works, but I should test carefully)