search

vowsjs / vows

Asynchronous BDD & continuous testing for node.js
http://vowsjs.org
Apache License 2.0
1.56k stars 165 forks source link

Variable _s leaking in bin/vows #340

Closed silkentrance closed 6 years ago

silkentrance commented 9 years ago

Lines 381ff

    function getMatchingTest(file, join) {
        join || (join = '-');
        var testFile;
        if (specFileExt.test(file)) {
            testFile = path.join(testFolder, file);
        }
        else {
            var root, extension;
            _s = file.split('.'), root = _s[0], extension = _s[1];
            testFile = path.join(testFolder, root + join + testFolder + "." + extension);

_s is not being declared and might leak...

evanp commented 6 years ago

This isn't the case in 1.x, so I'm closing this.