search

voxeet / comms-sdk-unity

Dolby.io Virtual World plugin for Unity.
https://api-references.dolby.io/comms-sdk-dotnet/documentation/unity/getting-started/installation.html
MIT License
16 stars 3 forks source link

Registering VideoControllers bug #65

Open leeprobert opened 11 months ago

leeprobert commented 11 months ago

The ConferenceController RegisterVideoControllers would break out of the iteration of VideoControllers after it found the local player. This prevented any other remote players from having their VideoTrack assigned.

dolby-io-open-source-tools[bot] commented 11 months ago

Hi @leeprobert! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and yours needs attention.

Process

In order for us to review and merge your suggested changes, please sign at https://contribute.dolby.io. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request check will be unlocked. MSG1001

leeprobert commented 11 months ago

I also added a public method to the ConferenceController to ensure you can register the delegate methods at any point and not just in the Start method.