Rename events related to video and screenshare - Githubissues

voxeet / comms-sdk-unreal

Dolby.io Virtual Worlds plugin for Unreal Engine

http://api-references.dolby.io/comms-sdk-unreal/

MIT License

26 stars 7 forks source link

Rename events related to video and screenshare #347

Closed kubaau closed 1 year ago

kubaau commented 1 year ago

Describe the feature request

The naming of the following events is confusing to some:

On Video Track Added/Removed
On Video Track Enabled/Disabled
On Video Enabled/Disabled
On Screenshare Started/Stopped

It would perhaps be better to rename them to:

On Remote Video Track Added/Removed
On Remote Video Track Enabled/Disabled
On Video Enabled/Disabled
On Screenshare Started/Stopped

or:

On Remote Video Track Added/Removed
On Remote Video Track Enabled/Disabled
On Local Video Track Video Added/Removed

or: split On Video Track Added/Removed into:

On Video Track Added/Removed
On Screenshare Track Added/Removed

It may also be convenient to change the logic of track Added/Enabled events or possibly remove the track Enabled/Disabled events altogether.

kubaau commented 1 year ago

Work stopped. WIP available at https://github.com/DolbyIO/comms-sdk-unreal/tree/delegate_refactor