Calling disconnect within screen sharing causes error

voxeet / comms-sdk-unreal

Dolby.io Virtual Worlds plugin for Unreal Engine

http://api-references.dolby.io/comms-sdk-unreal/

MIT License

27 stars 7 forks source link

Calling disconnect within screen sharing causes error #406

Closed AntonIovbakDev closed 1 year ago

AntonIovbakDev commented 1 year ago

Describe the bug

If user close UE app during a screensharing, error appears. Disconnect method called for dolby plugin within shutdown the UE5 app, exit or alt-F4, both cause the error

Expected Behavior

Don't have any errors by closing app.

Specifications

OS: windows 10
Version:
- UE5 v5.2.1
- dolby v1.1.6 cppsdk-2023-09-13-15-59-09.log

Now we are using hotfix just like that, but maybe it is not a proper way to handle it:

kubaau commented 1 year ago

@AntonIovbakDev This is probably similar to #374 which was fixed with https://github.com/DolbyIO/comms-sdk-unreal/pull/375/commits/dc048a1d849887d4c6210a25d59a87064c214aba . It looks likely that 1.2.0 will never come out of beta and I may be unable to release a patch for 1.1. I suggest using the main branch of this repository instead of the releases in that case.

kubaau commented 1 year ago

I ported that patch and released version 1.1.8. I am not sure if this fixes this exact issue, but the project will no longer be maintained so this is the best I can do now. Regardless, I recommend using version 1.2.0 instead.