Adjusted file targeting to point to new TS files rather than JS.

voxeet / voxeet-uxkit-cordova

Dolby.io UXKit for Cordova

Other

1 stars 14 forks source link

Adjusted file targeting to point to new TS files rather than JS. #3

Closed bijanmmarkes closed 5 years ago

bijanmmarkes commented 5 years ago

Fixed file references, plugin.xml was still referencing .js files although they were changed to .ts

codlab commented 5 years ago

For compatibility with non typescript project, this PR is rejected

bijanmmarkes commented 5 years ago

The files within this repository are .ts - the build fails due to this exact reason, the plugin.xml is referencing .js so the build fails: https://github.com/voxeet/voxeet-cordova-conferencekit/blob/master/plugin.xml#L29

https://github.com/voxeet/voxeet-cordova-conferencekit/blob/master/www/Voxeet.ts https://github.com/voxeet/voxeet-cordova-conferencekit/blob/master/www/UserInfo.ts

codlab commented 5 years ago

I'll maybe update in the future to only have the root folder being a copy of the transformed ts file but this repo is now focusing on providing the means to provide the required element onto npmjs only.

Hence, no modification whatsoever for the plugin.xml which is only targetting transformed files and not the typescript's compatible sources