Closed tuneerclixlogix closed 3 years ago
What are your connect() arguments?
@codlab Below user object
{
externalId: user_id,
name: firstName,
avatarUrl: photos[0],
}
What are the possible values of each of those variables?
The possible values are user_id: string name: string avatarUrl: string (AWS s3 bucket url)
@vjard can you check this, seems a regression in the SDK itself
@tuneerclixlogix Cannot reproduce it on develop branch with the following code:
import { VoxeetSDK, ConferenceUser } from "@voxeet/react-native-voxeet-conferencekit";
const user = new ConferenceUser("18", "Vincent", "");
VoxeetSDK.connect(user)
...
Are you sure that values are string on client side?
Edit: Oh, I've the crash with null on avatarUrl, checking that.
@tuneerclixlogix Merge request has been approved, should works on develop branch now. Waiting your feedback before closing this ticket.
Thanks @vjard @codlab , if it happened with null or undefined then i will also apply checks for these at application side, can i send the blank string if there is any null or undefined value in avtarUrl ?
@tuneerclixlogix Yes you can. :) But I've fixed the problem on Objective-C side, so it will not happen anymore, even with null or undefined.
Thanks @vjard
@codlab @FabienLavocat Our users are recently facing the below crash on iOS , this is when the installation is with the develop branch -[NSNull _fastCStringContents:]: unrecognized selector sent to instance 0x1eb639ee0