search

voxel / voxel-clientmc

Minecraft client using WebSockets and voxel-engine (voxel.js plugin)
57 stars 13 forks source link

dependency minecraft-protocol requires node-gyp, introduces difficulty building on Windows #7

Closed deathcap closed 9 years ago

deathcap commented 10 years ago 
"minecraft-protocol": "git://github.com/deathcap/node-minecraft-protocol.git#e7be6eef4e5f7db8a4a87626f5e253f995624310",

node-gyp rebuild node-gyp configure build && node install.js (node-gyp rebuild 2> builderror.log) || (exit 0) node-gyp configure build && node install.js (node-gyp rebuild 2> builderror.log) || (exit 0)

reported in https://github.com/deathcap/voxpopuli/issues/52 causes installation troubles on Windows platforms

node-gyp is for native encryption code, not actually needed for voxel-clientmc but it is built as part of minecraft-protocol https://github.com/andrewrk/node-minecraft-protocol

deathcap commented 10 years ago

ref https://github.com/andrewrk/node-minecraft-protocol/pull/71 - "browser": in package.json avoids gyp dependency for the browser, but it is still built as part of the installation process. Maybe we need a packet-decoding-only fork of minecraft-protocol (no crypto) @roblabla thoughts?

roblabla commented 10 years ago

I've been thinking of separating minecraft-protocol and the barebone client nowadays.

Then you can probably use this in your project without problem.

I'll try adding this in this week.

deathcap commented 10 years ago

also ursa (the native RSA crypto module dependency) is now no longer maintained: https://github.com/Medium/ursa/commit/5786b41a829b6048a6f87a9f9aa48074d4fa7cac

roblabla commented 10 years ago

Well so long as it works, it doesn't matter. Besides, I'm not aware of any alternatives

On September 24, 2014 3:56:15 AM CEST, deathcap notifications@github.com wrote:

also ursa (the native RSA crypto module dependency) is now no longer maintained: https://github.com/Medium/ursa/commit/5786b41a829b6048a6f87a9f9aa48074d4fa7cac

Reply to this email directly or view it on GitHub: https://github.com/deathcap/voxel-clientmc/issues/7#issuecomment-56615647

Sent from my Android phone with K-9 Mail. Please excuse my brevity.

roblabla commented 10 years ago

Been working on some other projects than node-minecraft-protocol. If you want to go packet-decoding-only, I suggest you fork node-minecraft-protocol and keep only protocol.js for now.

deathcap commented 9 years ago

Solved with the browser field, https://github.com/PrismarineJS/node-minecraft-protocol/pull/71 - also; though ursa is still installed on nodejs, ursa-purajs now works well as an alternative if ursa cannot be built.

As for https://github.com/deathcap/voxelmetaverse/issues/52, removed voxel-clientmc from that repo for now, instead testing in a separate, bundled app https://github.com/deathcap/voxel-clientmc/tree/master/app