voxel51 / eta

ETA: Extensible Toolkit for Analytics
https://voxel51.com
Apache License 2.0
29 stars 13 forks source link

adding retry to gcs client upload and download methods #563

Closed Anddraca closed 2 years ago

Anddraca commented 2 years ago

Small update to make sure that the GCS storage client upload and download methods are using the Retry object defined on the class.

brimoor commented 2 years ago

nit: PR conventions:

Anddraca commented 2 years ago

Thanks for the points on setting up the PR -- I had assigned myself on a different issue but missed this one :grimacing:

As for the other methods: those do all take the retry object. I'll add those on if that's the desired behavior

Anddraca commented 2 years ago

Awesome. I did go through the other methods at this level, I think we're good for implementing retries for the GCS client