Closed brimoor closed 1 year ago
@ehofesmann yeah that would be nice too. Unfortunately it's not possible with the current implementation because the sample/label IDs at the time the embeddings
/points
are computed are not currently saved in the brain results. We should definitely change that so that, going forward, all new brain results can gracefully handle deleted data.
Well, I guess the specific thing you mentioned is possible (deleting data between when the results are loaded and when you call a method on the results object), but the more general problem of data being modified between the computation and loading of the results is the thing I'd like to solve 🤗
Adds an optional
allow_missing=True
flag to:that allows the method to gracefully continue in cases where
view
contains data points that theresults
index does not have data for. The examples below illustrate why this is useful.In practice,
allow_missing=True
will likely be needed becausecompute_similarity()
andcompute_visualization()
are not automatically updated, and, therefore, if one adds new samples to a dataset and then tries to fire up a visualization for a dataset that now has new data points, the lack of embedding data will need to be gracefully handled.Any in-App visualization should likely have an alert when
missing_size > 0
:Images example
Object patches example