voxel51 / fiftyone-docs-search

Search docs.voxel51.com with an LLM!
Apache License 2.0
356 stars 60 forks source link

Potential OS compatibility issues #2

Closed ehofesmann closed 1 year ago

ehofesmann commented 1 year ago

I need to verify, but I believe there might be issues using os.system(...) and calling unix commands like the following example:

https://github.com/voxel51/fiftyone-docs-search/blob/f3f24baf86ff15153f3ba7e904da426ca94c9376/fiftyone/docs_search/create_index.py#L264

Some of these commands may not be compatible on other OSs like Windows. Instead, you can probably use explicit methods like os.mkdir() in this case.

ehofesmann commented 1 year ago

Resolved by #3