[BUG] InvalidStateError: Failed to execute 'drawImage' on 'CanvasRenderingContext2D'

tomeravgil commented 1 year ago

Instructions

Thank you for submitting an issue. Please refer to our issue policy for information on what types of issues we address.

Please fill in this template to ensure a timely and thorough response
Place an "x" between the brackets next to an option if it applies. For example:
- [x] Selected option
Please delete everything above this line before submitting the issue

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Python version (python --3.11):
FiftyOne version (fiftyone --0.21.0):
FiftyOne installed from (pip):

Commands to reproduce

As thoroughly as possible, please provide the Python and/or shell commands used to encounter the issue. Application steps can be described in the next section.

Hi, I am trying to run a database with .avi and .mp4 files. For now I am not using reencodevideos, but I am getting a problem randomly.

# commands here

Describe the problem

Describe the problem clearly here. Include descriptions of the expected behavior and the actual behavior.

Code to reproduce issue

Provide a reproducible test case that is the bare minimum necessary to generate the problem.

Other info/logs

Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Please do not use screenshots for sharing text. Code snippets should be used instead when providing tracebacks, logs, etc.

What areas of FiftyOne does this bug affect?

[ X ] App: FiftyOne application issue
[ ] Core: Core Python library issue
[ ] Server: FiftyOne server issue

Willingness to contribute

The FiftyOne Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the FiftyOne codebase?

[ ] Yes. I can contribute a fix for this bug independently
[ X ] Yes. I would be willing to contribute a fix for this bug with guidance from the FiftyOne community
[ ] No. I cannot contribute a bug fix at this time

benjaminpkane commented 1 year ago

Hi @tomeravgil, this looks like an edge case issue with image data. Do you have example data that reproduces this issue? To start, I will look into 0x0 images

jneeven commented 5 months ago

I doubt @tomeravgil will have had the same cause, but I ran into this issue as well. After a lengthy elimination process, it turns out to be because I have a fo.Detection with an empty mask array. Setting the mask to None fixes the problem.

To reproduce:

          broken_dataset = fo.Dataset.from_json("debug.json", name="debug")

          # Fix broken mask
          sample = broken_dataset.first()
          for detection in sample["labels"]["detections"]:
              if detection.mask.size == 0:
                  detection.set_field("mask", None)

          dataset = broken_dataset.clone()
          dataset.clear()
          dataset.add_sample(sample)

      with record_function("launch_app"):
          # sesh = fo.launch_app(broken_dataset)
          sesh = fo.launch_app(dataset)

The loaded JSON file: debug.json And the image it refers to: 000000247306

voxel51 / fiftyone