search

voxel51 / fiftyone

The open-source tool for building high-quality datasets and computer vision models
https://fiftyone.ai
Apache License 2.0
7.93k stars 521 forks source link

add translate on shift + left mouse #4366

Closed sashankaryal closed 2 months ago

sashankaryal commented 2 months ago

What changes are proposed in this pull request?

New camera controls doesn't have translate on shift + left click by default. Instead, it uses right mouse drag, or two-finger move / three-finger move on trackpads. This isn't consistent with our prior CX, which used shift + click for trucking. This PR fixes that.

Also adds dolly on control + left mouse drag.

How is this patch tested? If it is not, please explain why.

Manually.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The updates in the looker-3d package aim to improve user interaction with 3D models, focusing on enhancing camera control shortcuts, adding new functionalities for camera configuration, and enhancing event handling. These changes aim to enhance user navigation and interaction within the 3D environment.

Changes

File Path Change Summary
.../action-bar/ViewHelp.tsx Updated camera control shortcuts and descriptions for translation and zoom actions.
.../fo3d/MediaTypeFo3d.tsx Added camera controls import, configuration function, and key event handlers.
.../action-bar/index.tsx Conditionally rendered <ViewFo3d jsonPanel={jsonPanel} /> based on the isFo3d flag.
.../hooks/use-hot-key.ts Modified the callback function in the useHotkey hook for proper context handling.
.../action-bar/ViewFo3d.tsx Added imports, state for isJsonPanelOpen, hotkey listener, and outside click handler.

Poem

🌟 A Whimsical Code Celebration by CodeRabbit 🌟

In the land of 3D, where models spin and sway,
A rabbit hopped in, with code patches to display.
"Shift + drag," it cheered, with a twinkle in its eye,
Now navigate with ease, as your models fly high!
With keys and controls, so finely tuned,
Dance through digital worlds, by the silvery moon. 🌙

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 16.02%. Comparing base (8d2b0f1) to head (2753171). Report is 116 commits behind head on develop.

:exclamation: Current head 2753171 differs from pull request most recent head 23d91af. Consider uploading reports for the commit 23d91af to get more accurate results

Files Patch % Lines
app/packages/looker-3d/src/fo3d/MediaTypeFo3d.tsx 0.00% 37 Missing :warning:
app/packages/looker-3d/src/action-bar/ViewHelp.tsx 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4366 +/- ## ============================================ - Coverage 99.26% 16.02% -83.25% ============================================ Files 42 804 +762 Lines 15738 89221 +73483 Branches 0 1340 +1340 ============================================ - Hits 15623 14300 -1323 - Misses 115 74921 +74806 ``` | [Flag](https://app.codecov.io/gh/voxel51/fiftyone/pull/4366/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | Coverage Δ | | |---|---|---| | [app](https://app.codecov.io/gh/voxel51/fiftyone/pull/4366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | `16.02% <0.00%> (?)` | | | [python](https://app.codecov.io/gh/voxel51/fiftyone/pull/4366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sashankaryal commented 2 months ago

@brimoor good idea. How do you like this? Also added a hotkey I for viewing FO3D.

2024-05-07 20 54 22