3D export fixes and tests

[swheaton]

Checkpointing my work in case I don't get to finish it.

1. added tests for at least 4 different configurations of fo3d data layout + relative vs. absolute + flatten vs. rel_dir.
2. Fixed a few bugs caught by tests
   • .mtl file in ObjMesh wasn't getting rewritten (it was only checking first asset path for each node)
   • use input to output asset path map to determine when we need to rewrite asset path in the fo3d file. fixes the case when flattening (no rel_dir) causes a file to be renamed from, say, pcd.pcd to pcd-2.pcd

The tests are absolutely horrendous on the eyes, I'm so sorry!! They could be refactored to something nicer but didn't have time right now.

What I would like to do if I have time:

• allow asset_dir
• make changes work with Teams which includes fos.resolve() and a cloud friendly os.path.relpath() if it doesn't already exist. Actually the latter probably just works but we would want to double check.
• make a batch media exporter that does this in bulk instead of one at a time. Then re-use that for fos.upload_media() and download_media() in Teams so we don't have the same fragile code implemented twice. With the side benefit that export should be faster.

Summary by CodeRabbit

• New Features
  • Introduced a method to update asset paths in 3D scenes, enhancing the management of asset locations based on user-defined mappings.
• Tests
  • Added new tests for 3D media handling, ensuring robustness and reliability in asset path updates and scene integrity.

[coderabbitai[bot]]

Walkthrough

The recent updates focus on enhancing asset path management within the Scene3D class and the data exporters of a software library. A new method, update_asset_paths, centralizes the process of updating paths based on a mapping dictionary. This method is now utilized in the data exporters to streamline path updates. Additionally, new unit tests ensure the functionality behaves as expected across various scenarios.

Changes

File Path	Change Summary
.../core/threed/scene_3d.py	Added update_asset_paths method to Scene3D class for updating asset paths.
.../utils/data/exporters.py	Enhanced asset path handling using the new update_asset_paths from Scene3D.
.../unittests/.../import_export_tests.py	New test class ThreeDMediaTests with methods to test asset path updates in various scenarios.

🐰✨ In the code where paths intertwine,
A rabbit hops with updates fine.
Paths now clear where once were knots,
Through tests and maps, it plots its spots.
Celebrate the code, fresh and new,
Hop along, there's more to view!
🌟🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[swheaton]

make a batch media exporter that does this in bulk instead of one at a time. Then re-use that for fos.upload_media() and download_media() in Teams so we don't have the same fragile code implemented twice. With the side benefit that export should be faster.

Ok I am seeing that this exists, sort of, in Teams when a cloud path is involved. I am unable to take this refactor on right now so perhaps I'll have to leave it alone for now.

[swheaton]

@coderabbitai review

[coderabbitai[bot]]

Actions Performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.