Closed imanjra closed 2 months ago
The update across the application integrates new functionalities like adding callbacks to operator execution, renaming components, and enhancing user interactions. These changes aim to streamline processes and improve both the user interface and system efficiency.
Files | Summary |
---|---|
.../MuiButton/index.tsx , .../components/index.ts |
Introduced MuiButton with a loading feature and updated exports. |
.../OperatorInvocationRequestExecutor.tsx , .../operators.ts , .../state.ts , .../types-internal.ts |
Enhanced operator execution with callbacks and updated related types and functions. |
.../Space.tsx , .../Workspaces/Workspace.tsx , .../Workspaces/WorkspaceEditor.tsx , .../Workspaces/constants.ts , .../Workspaces/hooks.ts , .../Workspaces/index.tsx , fiftyone/operators/builtin.py |
Renamed components from SavedSpaces to Workspaces and updated related operations and hooks. Adjusted operator names and functionalities in backend scripts. |
🐇✨ In the land of code, where the bits align, A rabbit hopped through, making changes fine. From
SavedSpaces
toWorkspaces
it roamed, Adding callbacks where the operators homed. With a hop and a skip, the updates shine, In the burrow of code, all now align. 🌟🐾
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@imanjra I'll defer to others for code review but I just tested this PR and everything looks and works great!
With respect to the positioning of the . Unsaved [icon]
component, I definitely prefer the new layout compared to the old one. Maybe decrease the right padding just a bit more so the right edge of the workspace icon aligns with the right edge of the grid reset icon?
What changes are proposed in this pull request?
How is this patch tested? If it is not, please explain why.
Using the workspaces in the app
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit
New Features
Workspaces
component.SavedSpaces
toWorkspaces
andSavedSpace
toWorkspace
for clarity and consistency.MuiButton
component with a loading indicator for enhanced user experience.Bug Fixes
Refactor
MuiButton
component in modified components and functions.Documentation