search

voxel51 / fiftyone

Refine high-quality datasets and visual AI models
https://fiftyone.ai
Apache License 2.0
8.72k stars 551 forks source link

Fix operators eslint issues #4388

Closed ritch closed 4 months ago

ritch commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent updates introduce several modifications across the app/packages/operators module, primarily focusing on refining the use of hooks, enhancing type definitions, and updating configurations. Key changes include disabling a specific ESLint rule, adding dependencies to useEffect hooks, refining method signatures, and updating type declarations. Additionally, minor adjustments were made to GitHub workflows by removing unnecessary installation steps.

Changes

File Path Change Summary
app/packages/operators/.eslintrc Introduced configuration to disable the react-hooks/rules-of-hooks rule.
app/packages/operators/babel.config.js Added a global comment for the module.
app/packages/operators/src/OperatorInvocationRequestExecutor.tsx Added dependencies to the useEffect hook in the RequestExecutor function.
app/packages/operators/src/built-in-operators.ts Updated method signatures and return types for several classes.
app/packages/operators/src/types.ts Updated Property constructor and added new properties to PropertyOptions.
app/packages/operators/src/OperatorPalette.tsx Changed SubmitButtonOption type from locally scoped to exported.
app/packages/operators/src/components/OperatorPromptFooter.tsx Updated type of submitButtonOptions in OperatorFooterProps to use SubmitButtonOption[].
app/packages/operators/src/operators.ts Added new types and updated method signatures in multiple classes.
.github/workflows/e2e.yml Removed pip install fiftyone-db-ubuntu2204 from the Install fiftyone job.
.github/workflows/test.yml Removed pip install fiftyone-db-ubuntu2204 from the Install fiftyone job.

Amidst the code, where changes bloom, A rabbit hops from room to room. With hooks refined and types in place, Our project moves at a steady pace. In workflows, clutter swept away, We code anew, come what may. 🐇✨

[!WARNING]

Review ran into problems

Problems (1) * Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 16.01%. Comparing base (2753171) to head (fd50a4e). Report is 60 commits behind head on develop.

:exclamation: Current head fd50a4e differs from pull request most recent head e365237

Please upload reports for the commit e365237 to get more accurate results.

Files Patch % Lines
app/packages/operators/src/built-in-operators.ts 0.00% 14 Missing :warning:
...perators/src/OperatorInvocationRequestExecutor.tsx 0.00% 6 Missing :warning:
app/packages/operators/src/types.ts 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4388 +/- ## =========================================== - Coverage 16.02% 16.01% -0.02% =========================================== Files 804 807 +3 Lines 89221 89351 +130 Branches 1340 1342 +2 =========================================== + Hits 14300 14308 +8 - Misses 74921 75043 +122 ``` | [Flag](https://app.codecov.io/gh/voxel51/fiftyone/pull/4388/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | Coverage Δ | | |---|---|---| | [app](https://app.codecov.io/gh/voxel51/fiftyone/pull/4388/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | `16.01% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.