search

voxel51 / fiftyone

The open-source tool for building high-quality datasets and computer vision models
https://fiftyone.ai
Apache License 2.0
7.93k stars 521 forks source link

require eslint for PRs #4391

Closed ritch closed 2 months ago

ritch commented 2 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

[!WARNING]

Rate Limit Exceeded

@benjaminpkane has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 59 minutes and 12 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 3b3dc8a48846cced9790b28dd77966e19c321a27 and 37bdfc62ff31950ccd4414ed02558f2bc8abdef3.

Walkthrough

The recent changes involve the introduction of a new GitHub Actions workflow for code linting triggered by pull requests. This includes adding a job named lint to an existing workflow and introducing the operators package in eslint-packages.txt.

Changes

File Path Change Summary
.github/workflows/pr.yml Added a new job lint to filter changes in app/ before running lint-app.yml.
app/eslint-packages.txt Introduces the operators package.
.github/workflows/lint-app.yml Sets up ESLint workflow in a Node.js environment for application linting.
app/packages/operators/.eslintrc Disables react-hooks/rules-of-hooks rule.
app/packages/operators/babel.config.js Added /* global module */ comment.
app/packages/operators/src/OperatorInvocationRequestExecutor.tsx Added // eslint-disable-next-line react-hooks/exhaustive-deps comment.
app/packages/operators/src/OperatorPalette.tsx Changed SubmitButtonOption type to an exported type.
app/packages/operators/src/built-in-operators.ts Various method signature and type updates.
app/packages/operators/src/components/OperatorPromptFooter.tsx Changed submitButtonOptions type and added import statement.
app/packages/operators/src/operators.ts Added types, updated method signatures, and properties in various classes.
app/packages/operators/src/types.ts Updated Property class constructor and added properties to PropertyOptions.

πŸ‡πŸ’»βœ¨
In the garden of code, where the wild rabbits hop,
A new linting path we now adopt.
With each push and pull, we refine,
Ensuring our code elegantly aligns.
Cheers to clean code, our forever quest,
With GitHub Actions, we're at our best! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.28%. Comparing base (2753171) to head (3b3dc8a). Report is 60 commits behind head on develop.

:exclamation: Current head 3b3dc8a differs from pull request most recent head 37bdfc6

Please upload reports for the commit 37bdfc6 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4391 +/- ## ============================================ + Coverage 16.02% 99.28% +83.25% ============================================ Files 804 46 -758 Lines 89221 16005 -73216 Branches 1340 0 -1340 ============================================ + Hits 14300 15890 +1590 + Misses 74921 115 -74806 ``` | [Flag](https://app.codecov.io/gh/voxel51/fiftyone/pull/4391/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | Coverage Ξ” | | |---|---|---| | [app](https://app.codecov.io/gh/voxel51/fiftyone/pull/4391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | `?` | | | [python](https://app.codecov.io/gh/voxel51/fiftyone/pull/4391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | `99.28% <ΓΈ> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.