Closed sashankaryal closed 4 months ago
The recent update involves enhancing the initialization methods of various light classes in the fiftyone/core/threed
module by adding a name
parameter. This improvement allows for better identification and management of light objects within 3D environments. Additionally, adjustments were made in MediaTypeFo3d.tsx
to handle camera properties more effectively.
File Path | Change Summary |
---|---|
fiftyone/core/threed/lights.py |
Added name parameter to __init__ methods for Light , AmbientLight , DirectionalLight , PointLight , and SpotLight . |
app/packages/looker-3d/src/fo3d/MediaTypeFo3d.tsx |
Adjusted canvasCameraProps creation to handle fov , near , far , lookAt , and aspect properties based on foScene?.cameraProps . |
🌟✨🐇 In the land of code, where the light classes play, A small change was made, brightening the day. "Name your lights," the developers said, Now each light shines bright, with a name overhead. Hoppity, skippity, let there be light! 🌟✨ 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Added a small comment, if we can pass in the class name in the parent class, we don't have to pass in the individual class name :)
What changes are proposed in this pull request?
Summary by CodeRabbit