search

voxel51 / fiftyone

The open-source tool for building high-quality datasets and computer vision models
https://fiftyone.ai
Apache License 2.0
7.93k stars 521 forks source link

fix point cloud bugs #4401

Closed sashankaryal closed 2 months ago

sashankaryal commented 2 months ago

What changes are proposed in this pull request?

  1. Add grid configurator grid

  2. Fix rgb shader not responding to point size change

  3. ~Center points geometry~

  4. Use points.clone() to do a shallow copy so that point clouds with same URL are treated as different copies in the scene graph

How is this patch tested? If it is not, please explain why.

Manual testing

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

[!IMPORTANT]

Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2) * `e2e-pw/src/oss/specs/3d/fo3d-pcd-stl.spec.ts-snapshots/scene-chromium-darwin.png` is excluded by `!**/*.png`, `!**/*.png` * `e2e-pw/src/oss/specs/3d/fo3d-pcd-stl.spec.ts-snapshots/scene-chromium-linux.png` is excluded by `!**/*.png`, `!**/*.png`

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates introduce significant enhancements to the looker-3d package, including new grid configuration options, updated component styling, and improved state management. Additionally, the PopoutSectionTitle component's styling was refined, and Docker image building scripts were optimized. These changes collectively improve the user interface, usability, and maintainability of the codebase.

Changes

File Path Change Summary
app/packages/components/src/components/PopoutSectionTitle/PopoutSectionTitle.tsx Added flexbox styling for better alignment and spacing in the PopoutSectionTitle component.
app/packages/looker-3d/src/action-bar/ToggleGridHelper.tsx Introduced a GridConfigurator component and updated ToggleGridHelper with new state management and UI elements.
app/packages/looker-3d/src/action-bar/shared.tsx Converted ActionPopOver to use forwardRef for better ref forwarding.
app/packages/looker-3d/src/action-bar/style.module.css Added new CSS classes for grid configuration styling.
app/packages/looker-3d/src/fo3d/Gizmos.tsx Updated grid-related calculations and state management using Recoil atoms.
app/packages/looker-3d/src/fo3d/point-cloud/Pcd.tsx Replaced useMemo with useEffect for point cloud data handling.
app/packages/looker-3d/src/hooks/use-pcd-material-controls.ts Increased the maximum pointSize value from 20 to 50.
app/packages/looker-3d/src/state.ts Added new Recoil atoms for grid settings.
e2e-pw/scripts/generate-screenshots-docker-image/build-docker-image.sh Updated script to exclude additional directories and added a Docker image build step.

In the realm of code, where changes dance, New features bloom, enhancing chance. With grids and styles, and Docker's might, The future of apps shines ever bright. Flex and atoms, all in line, A rabbit's joy in every sign. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/v0.24.0@d1b48f2). Learn more about missing BASE report.

:exclamation: Current head 53a8f82 differs from pull request most recent head 9d8cad7

Please upload reports for the commit 9d8cad7 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/v0.24.0 #4401 +/- ## ================================================== Coverage ? 99.27% ================================================== Files ? 47 Lines ? 16155 Branches ? 0 ================================================== Hits ? 16038 Misses ? 117 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/voxel51/fiftyone/pull/4401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | Coverage Ξ” | | |---|---|---| | [python](https://app.codecov.io/gh/voxel51/fiftyone/pull/4401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51) | `99.27% <ΓΈ> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxel51#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.