Closed sashankaryal closed 1 month ago
[!IMPORTANT]
Review Skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent changes introduce support for 3D datasets and projections in the Looker package. Key updates include adding a convexHull
property to the DetectionLabel
interface, enhancing 3D and 2D projection utilities, and incorporating a normal
field in the OrthographicProjectionMetadata
type. Additionally, a new 3D dataset, "Quickstart 3D," is documented and implemented, with corresponding updates in test files to ensure the new functionalities are well-covered.
Files & Paths | Change Summaries |
---|---|
app/packages/looker/src/overlays/detection.ts |
Added convexHull property to DetectionLabel and updated rendering logic to draw convex hulls. |
app/packages/looker/src/state.ts |
Updated OrthographicProjectionMetadata to include a normal field with three numbers. |
app/packages/looker/src/worker/label-3d-projection-utils.test.ts app/packages/looker/src/worker/label-3d-projection-utils.ts |
Added utility functions and types for 3D point rotation and 2D projection. |
app/packages/looker/src/worker/threed-label-processor.ts |
Enhanced functions to handle 3D bounding boxes and projections, added imports and new logic for convex hull computation. |
docs/source/user_guide/dataset_zoo/datasets.rst |
Added documentation for the new "Quickstart 3D" dataset with details and example usage. |
fiftyone/utils/utils3d.py |
Updated OrthographicProjectionMetadata class to include a normal attribute. |
fiftyone/zoo/datasets/base.py |
Introduced Quickstart3DDataset class for managing the new 3D dataset. |
tests/unittests/utils3d_tests.py |
Modified tests to include assertions for the normal field in OrthographicProjectionMetadata . |
🐇 In the world of Looker, 3D thrives, With convex hulls and projections alive. Quickstart 3D joins the fray, Bounding boxes now in a new way. Orthographic views with normals, how grand, Our datasets and tests, perfectly planned. 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What changes are proposed in this pull request?
Project 3d bounding box to 2d plane, and fill the convex hull of the resulting point set. Still needs refinement.
Summary by CodeRabbit
New Features
Quickstart3DDataset
class for handling 3D datasets with meshes, point clouds, and oriented bounding boxes.Enhancements
normal
field.Bug Fixes
Documentation