Closed benjaminpkane closed 1 month ago
The updates primarily focus on enhancing the operator prompt configuration and handling in the codebase. This includes refactoring components for better organization, adding attributes for testing, and updating functionalities for prompts in modals, drawers, and view modals. Additionally, new end-to-end (E2E) test operators and test cases were introduced, and version increments were made in the setup files.
Files | Change Summary |
---|---|
app/packages/operators/src/OperatorPrompt/OperatorDrawerPrompt.tsx |
Added scrollable import, data attributes for testing, and restructured layout with Box and Stack components. |
app/packages/operators/src/OperatorPrompt/OperatorModalPrompt.tsx |
Refactored to use a single promptConfig object for handling operator prompt configurations. |
app/packages/operators/src/OperatorPrompt/OperatorViewModal.tsx |
Added dialogProps property with data-cy attribute for testing purposes. |
app/packages/operators/src/OperatorPrompt/index.tsx |
Removed condition checking for prompt.resolvedIO.input and prompt.resolvedIO.output . |
app/packages/operators/src/utils.ts |
Updated getOperatorPromptConfigs function to handle loading states, submission disabling, and setting disabled reason and onClose behavior. |
e2e-pw/src/oss/poms/operators/operators-prompt.ts |
Introduced OperatorsPromptPom class with methods for executing, canceling, closing, and validating prompts, and OperatorsPromptAsserter class for asserting prompt states. |
e2e-pw/src/oss/specs/operators/built-in-operators.spec.ts |
Removed HistogramPom import and histogramPanel declaration, adjusted datasetName declaration. |
e2e-pw/src/oss/specs/operators/prompt.spec.ts |
Added new test cases for interacting with prompts in an operators browser, including canceling, validating input, executing actions, and checking progress indicators. |
e2e-pw/src/shared/assets/plugins/e2e/__init__.py |
Added classes E2ESayHelloInModal , E2ESayHelloInDrawer , and E2EProgress for E2E tests. |
e2e-pw/src/shared/assets/plugins/e2e/fiftyone.yml |
Added new operators for E2E tests: e2e_say_hello_in_modal , e2e_say_hello_in_drawer , e2e_progress . |
package/desktop/setup.py |
Updated version from "0.34.0" to "0.34.1". |
setup.py |
Updated version from "0.24.0" to "0.24.1" and updated dependency version for fiftyone-desktop . |
In the land of code, new changes bloom,
Operators dance in their prompt-filled room.
With drawers and modals, they now align,
Testing made easy, everything's fine.
E2E tests sing a brand new tune,
Version bumps shine like stars and moon.
Hopping forward, our code does gleam,
A rabbit's delight, in this dream. 🌟🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Merge
release/v0.24.1
intodevelop
Summary by CodeRabbit
New Features
Bug Fixes
Chores