voxel51 / fiftyone

The open-source tool for building high-quality datasets and computer vision models
https://fiftyone.ai
Apache License 2.0
7.87k stars 518 forks source link

Cherry picking PRs into v0.24.1 #4455

Closed brimoor closed 4 weeks ago

brimoor commented 1 month ago

These PRs were included in the release notes for 0.24.0 but somehow appear to have not actually been released (I've moved their associated release notes into v0.24.1 in https://github.com/voxel51/fiftyone/pull/4456):

Also cherry-picks these bug fixes:

And the following PR which just missed the cutoff from v0.24.0 but has tests:

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@brimoor has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 2 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 2350e7420791ae9b8120b7dec1c97f877cdc94bb and 74cc85d5bfa6cadaa8673bc0e8511a05e12025ec.

Walkthrough

The recent changes enhance FiftyOne's functionality, especially in handling datasets, 3D scenes, and video processing. Key updates include new parameters for dataset persistence and generation, refined asset path handling, and improved metadata processing for 3D scenes. Additionally, new test methods ensure robustness, and various refinements streamline CVAT integration and dataset export logic.

Changes

File(s) Change Summary
docs/source/teams/cloud_media.rst Added methods for downloading scenes, including 3D assets, with configurable options.
fiftyone/core/clips.py, fiftyone/core/patches.py, fiftyone/core/video.py Added persistent and _generated parameters to dataset creation functions for better control over persistence and generation.
fiftyone/core/dataset.py Corrected a comment related to sample_id association with frames in clips datasets.
fiftyone/core/metadata.py Enhanced SceneMetadata class with new methods for handling 3D scene metadata and asset parsing.
fiftyone/core/stages.py Added _generated=True parameter to several function calls within the load_view method.
fiftyone/core/storage.py Renamed resolve to realpath and updated docstrings for clarity. Modified abspath to handle relative path indicators better.
fiftyone/core/threed/object_3d.py, fiftyone/core/threed/scene_3d.py Improved handling of asset paths within Object3D and Scene classes, including logic refinements and efficient storage.
fiftyone/utils/cvat.py, fiftyone/utils/data/exporters.py, fiftyone/utils/utils3d.py Refined parameter descriptions, improved logic for handling annotations, and adjusted path resolution for 3D assets.
tests/intensive/cvat_tests.py, tests/unittests/metadata_tests.py, tests/unittests/patches_tests.py, tests/unittests/threed/scene_3d_tests.py, tests/unittests/utils3d_tests.py, tests/unittests/video_tests.py Added new test methods and adjusted existing ones to ensure robustness and proper functionality of new features.

Poem

In the land of code, where datasets grow,
New methods bloom, like flowers in snow.
With assets in 3D, and scenes to download,
Persistent and generated, a story unfolds.
Tests now ensure, all runs smooth and bright,
As FiftyOne evolves, in the digital light.
🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.