search

voxel51 / fiftyone

The open-source tool for building high-quality datasets and computer vision models
https://fiftyone.ai
Apache License 2.0
7.87k stars 518 forks source link

fix workspace persistence issue #4471

Closed imanjra closed 3 weeks ago

imanjra commented 3 weeks ago

What changes are proposed in this pull request?

Fixes some issues with loading and using workspaces in the app

How is this patch tested? If it is not, please explain why.

Using app and session

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

See above

What areas of FiftyOne does this PR affect?

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

This update introduces several enhancements and refactors across multiple files. Key changes include the integration of a new clearSpaces function in the MainSpace component, the addition of a QueueItemStatus enum for better status management in OperatorInvocationRequestExecutor, and improved state handling in the spaces package. Additionally, build configurations have been updated to include new MongoDB download links and artifact upload steps.

Changes

Files Change Summary
.../MainSpace/MainSpace.tsx Modified useSpaces to include clearSpaces and added an useEffect hook to call clearSpaces on mount.
.../OperatorInvocationRequestExecutor.tsx Added useMemo to filter requests by QueueItemStatus.Pending and updated rendering to use pendingRequests.
.../constants.ts Added QueueItemStatus enum with Pending, Executing, Completed, and Failed values.
.../operators.ts Moved QueueItemStatus enum to constants.ts and updated imports accordingly.
.../spaces/src/hooks.ts Replaced useEffect with conditional state setting, added clearSpaces function using useCallback, and updated dependencies.
.../spaces/src/state.ts Modified spacesAtom declaration to allow SpaceNodeJSON values to be undefined.
.github/workflows/build-db.yml Added a new step to upload a wheel artifact if the platform is not 'sdist', with a specific name and path.
package/db/setup.py Added MongoDB download links for CentOS 7, 8, 9, Debian 9, and Windows (amd64). Updated version to "1.1.3" and modified _get_download() function for Windows support.

Poem

In code's vast and winding maze,
We clear the spaces, set ablaze,
With enums guiding status bright,
Pending, done, in day and night.
Mongo links for all to see,
Our build now flows with clarity.
🌟🚀

[!WARNING]

Review ran into problems

Problems (1) * Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
brimoor commented 3 weeks ago

@imanjra @benjaminpkane confirmed that workspace persistence works when navigating between datasets via the dataset selector in the App (although I believe the real test bed is Teams here, not OSS).

Similar to https://github.com/voxel51/fiftyone/pull/4469#issuecomment-2156058282, I did notice that if I manually remove ?workspace=WORKSPACE from the URL bar and press ENTER, the workspace is added back to the URL.

However, unlike for saved views, if I navigate from http://localhost:5151/datasets/DATASET1?workspace=WORKSPACE directly to http://localhost:5151/datasets/DATASET2, it does correctly load the second dataset without carrying over the workspace.

imanjra commented 3 weeks ago

Similar to https://github.com/voxel51/fiftyone/pull/4469#issuecomment-2156058282, I did notice that if I manually remove ?workspace=WORKSPACE from the URL bar and press ENTER, the workspace is added back to the URL.

This is intentional for both workspaces and saved views to recover app state based on the current session state. However, changing the workspace/view param in URL to some other workspace/view should trigger session to update along with the app.

imanjra commented 3 weeks ago

Updated the base to merge/v0.24.1-to-main