search

voxel51 / fiftyone

The open-source tool for building high-quality datasets and computer vision models
https://fiftyone.ai
Apache License 2.0
7.87k stars 518 forks source link

Add sidebar value text expansion #4487

Closed benjaminpkane closed 3 weeks ago

benjaminpkane commented 3 weeks ago

What changes are proposed in this pull request?

Adds text expansion option via container click.

https://github.com/voxel51/fiftyone/assets/19821840/2d48f0e9-b4a7-4378-8ca1-beb633b90e21

How is this patch tested? If it is not, please explain why.

Locally

import fiftyone.zoo as foz

LOREM = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."

dataset = foz.load_zoo_dataset(
    "quickstart", max_samples=1, dataset_name="long-text"
)

sample = dataset.first()
sample["lorem"] = LOREM
sample["lorems"] = [LOREM, LOREM]
sample.save()

Release Notes

What areas of FiftyOne does this PR affect?

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes in PathValueEntry.tsx include enhancements to state management and rendering logic for expanded entries and text within the component. They also introduce new imports and styled components, such as LoadingDots, FRAME_SUPPORT_FIELD, TitleDiv, and modifications in ScalarDiv. These updates improve the handling of expandable sections and visual adjustments in the sidebar.

Changes

Files involve Change Summaries
.../PathValueEntry.tsx - Addition of LoadingDots import
- Addition of FRAME_SUPPORT_FIELD import
- Changes in the useRecoilState import
- Addition of expandedPathValueEntry atomFamily
- Addition of TitleDiv styled component
- Changes in ScalarDiv styled component
- Addition of state management for expanded entries
- Changes in rendering logic for expanded entries in ScalarValueEntry and ListValueEntry
- Addition of state management for expanded text in ListValueEntry
- Changes in rendering logic for expanded text in ListValueEntry, ListLoadable, SlicesListLoadable, and SlicesLoadable
- Changes in styling and layout adjustments

Poem

By my burrow, I see the code,
Expanded paths now take the load.
With LoadingDots and TitleDiv,
In lists and scalars, entries live.
State is managed clear and fine,
Where once was plain, now all align.
Hopping through these fields and frames,
The sidebar shines, enhanced with names.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
brimoor commented 3 weeks ago

@benjaminpkane couple UX thoughts here:

benjaminpkane commented 3 weeks ago

@benjaminpkane couple UX thoughts here:

  • would be nice if the cursor changed to indicate that something will happen when you click to expand/contract
  • just want to confirm: is it still possible to drag-select the text if you want to ctrl + C a portion of the long string?

Text selection is still possible. I will add the pointer cursor when outside text