Open ZoeHermansVintecc opened 1 month ago
Hi @ZoeHermansVintecc 👋
I believe this is fixed by https://github.com/voxel51/fiftyone/pull/4636, which is available on develop
now and will be released as part of fiftyone==0.25.0
which is slated for release on Monday, August 19!
Describe the problem
An error occurs when using the compute_visualization method from the FiftyOne brain plugin in the app. This issue arises specifically when the view in the app is set to "patch view." The objective is to view images at the patch level, create embeddings for the patches, and make a subset of these patches for reclustering to perform more in-depth data curation. However, the compute_visualization method fails when computing the visualization while on "patch view".
Code to reproduce issue
The issue arises when using the compute_visualization plugin in the app.
Steps to reproduce
The following error will occur after a few seconds.
Extra information
I wanted to note that when computing visualization via the plugin, the following arguments are passed to the compute_visualization function:
When calling the function when the app is in "image-view", the target_view variable is of the class 'fiftyone.core.view.DatasetView'. However, when calling the function from "patch-view", target_view is of the class 'fiftyone.core.patches.PatchesView'.
The code fails when running
sample_ops, frame_ops = sample._save(deferred=False)
. I believe this is because sample is None, which makes sense as the code tries to iterate over the samples of the dataset, but the dataset consists of patches.System information
Willingness to contribute
The FiftyOne Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the FiftyOne codebase?