search

voxel51 / fiftyone

Refine high-quality datasets and visual AI models
https://fiftyone.ai
Apache License 2.0
8.72k stars 551 forks source link

Fixing #4627 #4674

Closed brimoor closed 1 month ago

brimoor commented 1 month ago

Resolves https://github.com/voxel51/fiftyone/issues/4627

As pointed out by @ChicoQi, the current implementation of the CVAT chunked video download chooses temp filenames with double .. in them:

file '/tmp/tmp44yd5t3h/0..mp4'
file '/tmp/tmp44yd5t3h/1..mp4'
file '/tmp/tmp44yd5t3h/2..mp4'
file '/tmp/tmp44yd5t3h/3..mp4'
file '/tmp/tmp44yd5t3h/4..mp4'
file '/tmp/tmp44yd5t3h/5..mp4'
file '/tmp/tmp44yd5t3h/6..mp4'
file '/tmp/tmp44yd5t3h/7..mp4'
file '/tmp/tmp44yd5t3h/8..mp4'
file '/tmp/tmp44yd5t3h/9..mp4'

and apparently some versions of ffmpeg don't like that.

With this patch, the temp filenames will have single .:

file '/tmp/tmp44yd5t3h/0.mp4'
file '/tmp/tmp44yd5t3h/1.mp4'
file '/tmp/tmp44yd5t3h/2.mp4'
file '/tmp/tmp44yd5t3h/3.mp4'
file '/tmp/tmp44yd5t3h/4.mp4'
file '/tmp/tmp44yd5t3h/5.mp4'
file '/tmp/tmp44yd5t3h/6.mp4'
file '/tmp/tmp44yd5t3h/7.mp4'
file '/tmp/tmp44yd5t3h/8.mp4'
file '/tmp/tmp44yd5t3h/9.mp4'

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent changes involve modifying the string formatting for file path generation in the _do_download_media function within the fiftyone/utils/cvat.py file. The dot separating the chunk ID from the file extension has been removed, changing the file naming convention. This adjustment may influence media concatenation processes and file retrieval mechanisms.

Changes

Files Change Summary
fiftyone/utils/cvat.py Modified string formatting for chunk_path in _do_download_media by removing the dot between chunk_id and ext.

Assessment against linked issues

Objective Addressed Explanation
Fix video concatenation failure (#4627) ❌ The change in file naming format may disrupt file retrieval needed for concatenation.

Poem

In the land of code, where rabbits hop,
I changed a dot, and now it won't stop!
Files will dance in paths anew,
Concat those videos, a joyous view!
With every fix, we bound and play,
Hopping along the coding way! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.