Closed CamronStaley closed 1 week ago
The changes involve updates to three files: Box.tsx
, indexes.py
, and query.py
. In Box.tsx
, a new optional height
property is added to the Box
component, allowing dynamic height adjustment instead of a hardcoded value. In indexes.py
, a conditional check is introduced to skip indexes marked as "in_progress" during processing. Lastly, in query.py
, the _assign_lightning_info
function is modified to include additional statistical data in index information retrieval.
File Path | Change Summary |
---|---|
app/packages/core/src/components/Filters/NumericFieldFilter/Box.tsx | Updated Box component to include an optional height property with a default value of 30; modified inline style to use height instead of a hardcoded value. |
fiftyone/server/indexes.py | Enhanced _from_dict function to skip processing of indexes marked as "in_progress". |
fiftyone/server/query.py | Updated _assign_lightning_info function to include include_stats=True in the call to fo_dataset.get_index_information() . |
NumericFieldFilter.tsx
involve the addition of a new styled component Box
, which is relevant to the modifications made to the Box
component in Box.tsx
in the main PR.NumericFieldFilter.tsx
changes include setting the height of the Box
styled component to 30 pixels, which aligns with the new height
property introduced in the Box
component in the main PR.NumericFieldFilter.tsx
include changes to the Box
component's styling, which is directly related to the updates made in the main PR regarding the Box
component.NumericFieldFilter.tsx
that involve the visibility of the button for showing the range slider are relevant as they may interact with the layout adjustments made in the Box
component from the main PR.EntryCounts
component in EntryCounts.tsx
include checks for the modal
state, which may relate to how the Box
component's height is utilized in different contexts as described in the main PR.enhancement
, app
🐰 In the meadow where rabbits play,
A newBox
has come to stay.
With height to change, oh what a sight,
It hops and bounces, pure delight!
While indexes skip, all in a row,
The stats come dancing, watch them go! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What changes are proposed in this pull request?
How is this patch tested? If it is not, please explain why.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit
New Features
Box
component now supports a dynamicheight
property, enhancing layout flexibility.Bug Fixes
_assign_lightning_info
function to improve index information retrieval.