voxmedia / autotune

Platform for reusable news tools
BSD 3-Clause "New" or "Revised" License
415 stars 37 forks source link

Fixes embed copy to clipboard button [lol maybe] #385

Closed yurivictor closed 7 years ago

yurivictor commented 8 years ago

What is this change?

Fixes this issue https://github.com/voxmedia/voxmedia-middleman-shared/issues/65. I hope.

$( '#embed textarea' ) didn't exist so I switched it to $( '#embedText' ) which does exist.

I also wrapped it into a try/catch, so that if the button doesn't work it should at least prompt the user to use their keyboard or whatever.

I tested this in console and it worked, but I have no idea how to test this locally because I can't seem to publish projects locally and since I can't publish I can't get an embed code and thus I can't test and that's where I'm at. Where are you?

Why is it being made?

Stuff broke.

Is this needed to publish a piece? Whats the deadline?

No deadline.

Is this specific to one vertical, or does it affect everyone?

This affects everything in the universe.

What are the risks?

The biggest risk is since I can't test this I may have made a typo causing a blocking js error that destroys all the javascript in autotune and the world ends, which is pretty bad imho.

Gif

ryanmark commented 7 years ago

:shipit: